Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Add variation attr to icons? #11883

Closed
Losses opened this issue Jun 17, 2018 · 6 comments
Closed

[Icons] Add variation attr to icons? #11883

Losses opened this issue Jun 17, 2018 · 6 comments
Labels
component: Icon The React component. design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request

Comments

@Losses
Copy link
Contributor

Losses commented Jun 17, 2018

https://material.io/tools/icons/ now provide multiple style of icons, what about adding these variation into @material-ui/icons ? Is variation a proper attr?

@Losses Losses changed the title Add variation attr to icons? [Icons] Add variation attr to icons? Jun 17, 2018
@oliviertassinari
Copy link
Member

We are waiting on the Google team to release the new icons set #11810.

@oliviertassinari oliviertassinari added the external dependency Blocked by external dependency, we can’t do anything about it label Jun 17, 2018
@hexetia
Copy link
Contributor

hexetia commented Jun 17, 2018

I created a repo with the new icons, we just need some tweaking to match the file structure of the google icons repository

https://github.com/saculbr/material-design-icons

some icons now have a different size from all the others (just 6 of them, you can view they here https://github.com/saculbr/material-design-icons/blob/master/index.js#L23), I can normalize them later
I think that this is a good starting point :)

@oliviertassinari oliviertassinari added the component: Icon The React component. label Jun 17, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 17, 2018

@saculbr Should we update our icon generator tool to scrape https://material.io/tools/icons/ instead of using https://www.npmjs.com/package/material-design-icons?

@hexetia
Copy link
Contributor

hexetia commented Jun 17, 2018

is a viable alternative while the official repository is not updated, the biggest pro to do the scrapping is to give a good experience to the devs, especially the beginners, because it's a little confusing not being able to find the site icons in the material-ui

the only con that I see in this strategy is that it will be a bit hard to know when new icons have been added, revised or removed

we can do a direct checksum in the icons source file (https://material.io/tools/icons/static/data.json) to do a temporary versioning (a good work around)

but this is not a big problem, we can go back when they update the official repository

@Losses
Copy link
Contributor Author

Losses commented Jun 17, 2018

@saculbr Really a good idea!

@hexetia
Copy link
Contributor

hexetia commented Jun 19, 2018

I can work on a poc this weekend

@oliviertassinari oliviertassinari added design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request and removed external dependency Blocked by external dependency, we can’t do anything about it labels Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Icon The React component. design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants