-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons] Add variation
attr to icons?
#11883
Comments
variation
attr to icons?variation
attr to icons?
We are waiting on the Google team to release the new icons set #11810. |
I created a repo with the new icons, we just need some tweaking to match the file structure of the google icons repository https://github.com/saculbr/material-design-icons some icons now have a different size from all the others (just 6 of them, you can view they here https://github.com/saculbr/material-design-icons/blob/master/index.js#L23), I can normalize them later |
@saculbr Should we update our icon generator tool to scrape https://material.io/tools/icons/ instead of using https://www.npmjs.com/package/material-design-icons? |
is a viable alternative while the official repository is not updated, the biggest pro to do the scrapping is to give a good experience to the devs, especially the beginners, because it's a little confusing not being able to find the site icons in the material-ui the only con that I see in this strategy is that it will be a bit hard to know when new icons have been added, revised or removed we can do a direct checksum in the icons source file (https://material.io/tools/icons/static/data.json) to do a temporary versioning (a good work around) but this is not a big problem, we can go back when they update the official repository |
@saculbr Really a good idea! |
I can work on a poc this weekend |
https://material.io/tools/icons/ now provide multiple style of icons, what about adding these variation into @material-ui/icons ? Is
variation
a proper attr?The text was updated successfully, but these errors were encountered: