Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typography] Variant display2 cuts of the bottom of a 'g' #12143

Closed
2 tasks done
Skaronator opened this issue Jul 13, 2018 · 4 comments
Closed
2 tasks done

[Typography] Variant display2 cuts of the bottom of a 'g' #12143

Skaronator opened this issue Jul 13, 2018 · 4 comments
Labels
bug 🐛 Something doesn't work component: Typography The React component. good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@Skaronator
Copy link
Contributor

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior

image

Steps to Reproduce (for bugs)

https://codesandbox.io/s/7wjrzyr5oj

Your Environment

Tech Version
Material-UI v1.3.1
React v16.4.1
browser Chrome Stable 64 Bit v67, Windows 10, 1080p
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. component: Typography The React component. labels Jul 13, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 13, 2018 •
edited
Loading

@Skaronator Thanks for the report. It seems to be a display2 only issue. What do you think of using 51 as line-height over 48?
https://github.com/mui-org/material-ui/blob/87595258c00b8d49aaf14e5e5dc8745e87e4c4f5/packages/material-ui/src/styles/createTypography.js#L64

@Skaronator
Copy link
Contributor Author

Yep 51 looks good!

@oliviertassinari
Copy link
Member

@Skaronator Feel free to submit a pull request :)

@oliviertassinari
Copy link
Member

Same issue on MWC:
capture d ecran 2018-07-14 a 12 45 08

@Skaronator Skaronator mentioned this issue Jul 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Typography The React component. good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Skaronator @oliviertassinari