Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListSubheader: disableGutters #12563

Closed
2 tasks done
johannwagner opened this issue Aug 17, 2018 · 3 comments
Closed
2 tasks done

ListSubheader: disableGutters #12563

johannwagner opened this issue Aug 17, 2018 · 3 comments
Labels
component: list This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@johannwagner
Copy link
Contributor

Hey Guys,

I just wanted to use a Subheader in a list with ListItems, which uses the disableGutters flag. But there is no disableGutters flag on the ListSubheader.

Is this intended behaviour or just a bug?

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

There should be a disableGutters flag on ListSubheader.

Current Behavior

There is no disableGutters flag on ListSubheader.

Steps to Reproduce

Link: https://codesandbox.io/s/p0xmqjoj0

Context

I want to accomplish, that the ListSubheader is in the same vertical row as the ListItems

If this is not intended and should be fixed, I would be very pleased to create a PR!

Your Environment

Tech Version
Material-UI v1.5.0
React 16.4.2
Browser Chromium Version 68
@oliviertassinari oliviertassinari added new feature New feature or request good first issue Great for first contributions. Enable to learn the contribution process. component: list This is the name of the generic UI component, not the React module! labels Aug 17, 2018
@oliviertassinari
Copy link
Member

@johannwagner You are right for symmetry, we should have a disableGutters property on the ListSubheader component! Do you want to work on it? :)

@johannwagner
Copy link
Contributor Author

Yep, I would give it a try. This is going to be my first contribution, so please be gentle 😄

@oliviertassinari
Copy link
Member

@johannwagner Don't worry about that 👼 .

@johannwagner johannwagner mentioned this issue Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @johannwagner