Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

row selection wrong for Enhanced Table in Component Demo after sorting on name (Dessert) #12566

Closed
2 tasks done
ericpyle opened this issue Aug 17, 2018 · 1 comment
Closed
2 tasks done
Assignees
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@ericpyle
Copy link

In the material-ui component demo for tables under "Sorting and Selecting", clicking to sort on Dessert column and then clicking on the name Kitkat, results in another row being selected, and KitKat changes to "Nougat".

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Selecting a name like "KitKat" should select that row

Current Behavior

"KitKat" changes to Nougat and a different row is selected

Steps to Reproduce

Link: https://material-ui.com/demos/tables/ under "Sorting & Selecting" or https://codesandbox.io/s/6vnol0pj2k

  1. Click to sort on the name column aka "Dessert (100g serving)" (See screenshot)

image

  1. Click on the second name "KitKat" to try to select that row
  2. Expected KitKat row to be selected. Got: KitKat changed to "Nougat" and 1 row is shown as selected, but not on the page. (See screenshot)

image

Link: https://github.com/mui-org/material-ui/blob/master/docs/src/pages/demos/tables/EnhancedTable.js

Context

Your Environment

Tech Version
Material-UI v1.5.0
React
browser Chrome
etc.
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: table This is the name of the generic UI component, not the React module! labels Aug 17, 2018
@oliviertassinari
Copy link
Member

Alright, it's my fault, I have messed it! I'm fixing it, thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants