-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility, animated components aren't focusable #13019
Comments
I don't know how to reproduce this. The only issue I have is that I have to tab twice before Disagree is focused. |
@eps1lon which screen reader have you used for testing? |
Firefox, Chrome, Chrome Vox. Excuse my ignorance here. Would like to know your setup. |
On my Windows 10 Box I use the NVDA screen reader along with Firefox. On Android I use Talkback along with Chrome. |
Took some time for me to get used to Talkback but I can see what the issue is now. An open drawer basically blocks the user from setting focus to anything within that drawer. Drawers in native apps work fine. Do have an example website that is using drawers like the one on the docs page on mobile devices? |
I did some digging and it's very like that the main issue is that aria-hidden is set to true not only on the backdrop but also on parent containers that contain the dialogs, drawers etc. It's working for the simple dialog example though. |
Yep, That is the issue I'm talking about. I don't know of a site, other than the MUI docs, that uses drawers. The argument is valid for dialogs though. |
This is only happening for Modals with |
No need to look far: https://material.io/design/color/the-color-system.html#color-theme-creation Works fine with TalkBack. Only problem is that it tabs through all elements in the page and not just the drawer. Still it's a bug with Modals and |
Expected Behavior
Animated components that use TransitionComponent prop (e.g Drawers, Dialogs) should be keyboard accessible after the transition animation. Moreover the focusable children (e.g Buttons, Links) of those components should be immediately focusable after their parent component is animated into view.
Current Behavior
The animated components which use the TransitionComponent prop (e.g Dialogs, Drawers) are not focusable after the animation. Moreover, the children of those animated components couldn't be navigated to using the Arrow keys, the tab key, or using touch.
Steps to Reproduce
The official component demos of the latest version of Material UI is used for testing.
Steps:
Context
Making components focusable is critical for those who use assistive technology. The menssioned problem render a lot of pages unusable when using a screen reader. For instance, it is very hard for me to access the different parts of the MUI website because the drawer used in the home page is not focusable.
Your Environment
The text was updated successfully, but these errors were encountered: