Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long tab names don't wrap in IE11 #13222

Closed
2 tasks done
amysutedja opened this issue Oct 12, 2018 · 4 comments
Closed
2 tasks done

Long tab names don't wrap in IE11 #13222

amysutedja opened this issue Oct 12, 2018 · 4 comments
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@amysutedja
Copy link

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Long tab names should wrap in Internet Explorer 11.

Current Behavior

Long tab names don't wrap.

Steps to Reproduce

Viewing the Material UI tabs with wrapped fields demo in IE11 immediately shows the issue.

https://material-ui.com/demos/tabs/

Context

A slim majority of our users are corporate users who are required to use IE11, so it's important for us to have as much visual parity as possible between IE11 and non-IE11 browsers.

Your Environment

Tech Version
Material-UI v1.3.0
React
Browser
TypeScript
etc.
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. labels Oct 13, 2018
@oliviertassinari
Copy link
Member

@amysutedja Nice catch, you should be able to add width: 100% to this style rule in order to solve the problem:
https://github.com/mui-org/material-ui/blob/5c70845cc4d60918c528f3aa58416ed8851a259c/packages/material-ui/src/Tab/Tab.js#L82
Do you want to work on it? :)

P.S. it seems we are using more divs than needed. We could try to remove some intermediate elements.

@patesson
Copy link
Contributor

I can pick this up if that's ok

@oliviertassinari
Copy link
Member

Sure :)

@patesson
Copy link
Contributor

Got a pull request here. #13230
I've not done one of these before so not sure if it's done right. Looks like it's failed its CI but I think that's expected due to the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

3 participants