Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot style SwipeArea component #13361

Closed
ZahaanKhan opened this issue Oct 23, 2018 · 9 comments
Closed

Cannot style SwipeArea component #13361

ZahaanKhan opened this issue Oct 23, 2018 · 9 comments
Labels
component: drawer This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@ZahaanKhan
Copy link

ZahaanKhan commented Oct 23, 2018 •
edited
Loading

SwipeArea does not contain 'name' attribute to override styles
@oliviertassinari oliviertassinari added good first issue Great for first contributions. Enable to learn the contribution process. component: drawer This is the name of the generic UI component, not the React module! new feature New feature or request labels Oct 23, 2018
@oliviertassinari
Copy link
Member

@ZahaanKhan I have been recently adding a name to all the Material-UI components. This can be used when generating global CSS, very handy. However, it's a private component, you are not supposed to target it this way. Instead, I think that we could be adding a SwipeAreaProps property so you can add your own class name to this element. Do you want to work on it?

@mdsadiq
Copy link
Contributor

mdsadiq commented Oct 24, 2018

Can i to take it up @ZahaanKhan @oliviertassinari ?

@oliviertassinari
Copy link
Member

Yes, sure :).

@ZahaanKhan
Copy link
Author

yes sure :). Thanks!

@oliviertassinari oliviertassinari added the hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 27, 2018
@imjaroiswebdev
Copy link
Contributor

Can i give it a try to this? @mdsadiq @ZahaanKhan @oliviertassinari

@mdsadiq
Copy link
Contributor

mdsadiq commented Oct 30, 2018 •
edited
Loading

@imjaroiswebdev I am working on it. will create a PR today
Apologies for having delayed it this long

@oliviertassinari oliviertassinari removed hacktoberfest https://hacktoberfest.digitalocean.com/ labels Nov 1, 2018
@captain-yossarian
Copy link
Contributor

@mdsadiq do you still working on it?

@mdsadiq
Copy link
Contributor

mdsadiq commented Nov 9, 2018

@SerhiiBilyk facing the issue when trying to build internally #12934, so waiting on that. But if you are able to hack around and make the changes feel free to work on it.

@captain-yossarian
Copy link
Contributor

@mdsadiq ok, thanks, tomorrow I will check it

@captain-yossarian captain-yossarian mentioned this issue Nov 13, 2018
Merged
1 task
@TommyJackson85 TommyJackson85 mentioned this issue Feb 11, 2020
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@oliviertassinari @mdsadiq @ZahaanKhan @captain-yossarian @imjaroiswebdev