Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix lost in versions - LinearPogress #13889

Closed
2 tasks done
jmarcosvillar opened this issue Dec 12, 2018 · 4 comments
Closed
2 tasks done

Bug fix lost in versions - LinearPogress #13889

jmarcosvillar opened this issue Dec 12, 2018 · 4 comments
Labels
component: LinearProgress The React component. component: progress This is the name of the generic UI component, not the React module! discussion

Comments

@jmarcosvillar
Copy link

There was a bug in the linear progress class, fixed in the following commit:
d32b93d

But in the nexts versions, the bug is lost.

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Current Behavior 😯

Steps to Reproduce 🕹

Link:

  1. Overriding LinearProgress's bar2Determinate styles not applied #12318
  2. d32b93d
Tech Version
Material-UI v3.0.3
React 16.3.0
Browser Chrome
TypeScript
etc.
@joshwooding
Copy link
Member

joshwooding commented Dec 12, 2018 •
edited
Loading

It was dead code #13712, so it was removed :)

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Dec 13, 2018
@oliviertassinari
Copy link
Member

@jmarcosvillar How is this an issue?

@jmarcosvillar
Copy link
Author

If this is not an issue, and it's dead code. There is a way you can modify the color of the bar2 when variant is determinate?

@oliviertassinari
Copy link
Member

@jmarcosvillar The bar2 won't be rendered when the variant is determinate, only bar1 will.

@oliviertassinari oliviertassinari added discussion component: LinearProgress The React component. and removed status: waiting for author Issue with insufficient information labels Dec 13, 2018
@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: LinearProgress The React component. component: progress This is the name of the generic UI component, not the React module! discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @joshwooding @jmarcosvillar