Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createSvgIcon has no type definition #13974

Closed
dabretin opened this issue Dec 21, 2018 · 3 comments
Closed

createSvgIcon has no type definition #13974

dabretin opened this issue Dec 21, 2018 · 3 comments
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@dabretin
Copy link
Contributor

It seems that @material-ui/icons/utils/createSvgIcon has no ".d.ts" typescript definition, so it's not possible to create custom icon in tsx.

Your Environment 🌎

Tech Version
Material-UI v3.7.0
React ^16.7.0-alpha.2
TypeScript ^3.2.2
@oliviertassinari oliviertassinari added typescript good first issue Great for first contributions. Enable to learn the contribution process. labels Dec 24, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 24, 2018 •
edited
Loading

@dabretin You are right. If anyone wants to contribute it, this would be perfect.

@yifei-fu yifei-fu mentioned this issue Dec 24, 2018
Merged
1 task
@yifei-fu
Copy link
Contributor

I made a PR #13994.

@dabretin
Copy link
Contributor Author

So much reactive that I could hope 👍
Thx a lot !

@mgansler mgansler mentioned this issue Feb 13, 2019
Closed
2 tasks
@eps1lon eps1lon mentioned this issue Feb 13, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @dabretin @yifei-fu