Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation v4 example typo Customization --> Theme -> Typography #15699

Closed
marcel-k opened this issue May 14, 2019 · 2 comments · Fixed by #15865
Closed

Documentation v4 example typo Customization --> Theme -> Typography #15699

marcel-k opened this issue May 14, 2019 · 2 comments · Fixed by #15865
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@marcel-k
Copy link

Took me a couple of hours before I found out why my code did not work but the v4 docs for theming typography contains a sneaky typo 👊

The example code overrides should be @font-face, not @font-family:

const theme = createMuiTheme({
  /* ... */
  overrides: {
    MuiCssBaseline: {
      '@global': {
         // '@font-family': [raleway],
        '@font-face': [raleway],
      },
    },
  },
});
@mbrookes mbrookes added the docs Improvements or additions to the documentation label May 14, 2019
@mbrookes
Copy link
Member

@marcel-k Would you like to submit a PR? You should be able to edit it directly in GitHub, since it's a one-line change. ("Edit this page" button should link you to the right file...)

@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants