Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwipeableDrawer] JS error when dragging it #16162

Closed
2 tasks done
eduardomcv opened this issue Jun 11, 2019 · 6 comments
Closed
2 tasks done

[SwipeableDrawer] JS error when dragging it #16162

eduardomcv opened this issue Jun 11, 2019 · 6 comments
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component.

Comments

@eduardomcv
Copy link
Contributor

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Though I found a similar issue, #12094, it's been closed since Jul 31, 2018, so I decided to create a new one.
The current behavior and steps to reproduce are the same.

Expected Behavior 🤔

No errors.

Current Behavior 😯

(copied from #12094)

When dragging the SwipeableDrawer, a JS error is continuously thrown in the console:
"[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted."

Here's a screenshot of the errors:

Screenshot from 2019-06-11 16-34-33

Steps to Reproduce 🕹

(copied from #12094)

  1. Use SwipeableDrawer in a project
  2. Open inspector console
  3. Once it's open, drag it slowly, in either direction
  4. You will notice a JS error for every drag movement

Context 🔦

Just trying to use SwipeableDrawer.

Your Environment 🌎

Tech Version
Material-UI v4.0.2
React 16.8.6
Browser Chrome
TypeScript 3.5.1

I'm using TypeScript on my current setup, so here's my tsconfig:

{
  "compilerOptions": {
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "preserve"
  },
  "include": [
    "src"
  ]
}
@oliviertassinari oliviertassinari changed the title SwipeableDrawer JS error when dragging it [SwipeableDrawer] JS error when dragging it Jun 11, 2019
@oliviertassinari
Copy link
Member

@eduardomcv Can you provide a reproduction?

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Jun 11, 2019
@oliviertassinari
Copy link
Member

v4.1.0 right?

@joshwooding
Copy link
Member

joshwooding commented Jun 11, 2019

v4.1.0 right?

Yep 👍 @eduardomcv Can you reproduce it in v4.1.0?

@eduardomcv
Copy link
Contributor Author

@joshwooding @oliviertassinari
Sorry for the delay. I can reproduce it it in 4.0.2 but not in 4.1.0, so it seems that the issue has been fixed.

@oliviertassinari
Copy link
Member

Nice :)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: SwipeableDrawer The React component. and removed status: waiting for author Issue with insufficient information labels Jun 12, 2019
@oliviertassinari oliviertassinari added the component: drawer This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component.
Projects
None yet
Development

No branches or pull requests

3 participants