Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component demos crashes in IE11 #16209

Closed
2 tasks done
tbruun opened this issue Jun 13, 2019 · 11 comments · Fixed by #16871
Closed
2 tasks done

Component demos crashes in IE11 #16209

tbruun opened this issue Jun 13, 2019 · 11 comments · Fixed by #16871
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it

Comments

@tbruun
Copy link

tbruun commented Jun 13, 2019

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Using IE11 should work on the demo site

Current Behavior 😯

On some components, IE11 crashes.
"[object Object] is not iterable!"

Steps to Reproduce 🕹

Visit one of the links with IE11

Link:

  1. https://material-ui.com/components/pickers/
  2. https://material-ui.com/components/tables/

Your Environment 🌎

Tech Version
Material-UI v4.1.1
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation external dependency Blocked by external dependency, we can’t do anything about it and removed docs Improvements or additions to the documentation labels Jun 13, 2019
@oliviertassinari
Copy link
Member

@tbruun Confirmed. But I don't think that it's the right place to open an issue:

Object doesn't support property or method 'includes'

U=function(e){return 2===e.length&&e.includes("month")&&e.includes("year")}

https://github.com/mui-org/material-ui-pickers/blob/689a36b0a5a06d64eb8ee19c33b21ae21eb790b0/lib/src/_helpers/date-utils.ts#L79
cc @dmtrKovalenko

Object doesn't support property or method 'find'

return this.parentFunc?t="tree":this.columns.find(function(e){return e.tableData.groupOrder>-1})&&(t="group"),e===t}},{key:"sort",value:function(e,t,n){if("numeric"===n)

https://github.com/mbrn/material-table/blob/05c513a76d7f350ee12459cbd0cd46052b165938/src/utils/data-manager.js#L279
cc @mbrn

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jun 13, 2019
@dmtrKovalenko
Copy link
Member

😱 😱 😱 😱
Will fix asap

@oliviertassinari
Copy link
Member

Thanks! :)

@tbruun
Copy link
Author

tbruun commented Jun 13, 2019

@oliviertassinari - Thanks for pointing it in the right direction :)

@mbrn
Copy link
Contributor

mbrn commented Jun 14, 2019

I will fix it asap.

@oliviertassinari
Copy link
Member

There is no urgency, I'm happy that it will eventually be fixed. IE 11 support is important for enterprises.

@dmtrKovalenko
Copy link
Member

Fixed IE issue in @mui-org/material-ui-pickers v3.1.1

@oliviertassinari
Copy link
Member

@dmtrKovalenko I can confirm it #16246 :)

@oliviertassinari
Copy link
Member

@mbrn Did you found the time to look into the issue :) ? An advanced table component is most valuable for enterprises, enterprises are more likely to require IE 11 support. I believe it's an important dimension for your project.

@mbrn
Copy link
Contributor

mbrn commented Jun 29, 2019

Hi @oliviertassinari ,

I am really very busy nowadays. But i will resolve this in 2 days:). Thanks for your patience.

@oliviertassinari
Copy link
Member

No problem, as long as it wasn't forgotten, we are 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
4 participants