Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js skeleton example fails when importing into codesandbox #16979

Closed
colemars opened this issue Aug 13, 2019 · 8 comments
Closed

Next.js skeleton example fails when importing into codesandbox #16979

colemars opened this issue Aug 13, 2019 · 8 comments
Labels
external dependency Blocked by external dependency, we can’t do anything about it

Comments

@colemars
Copy link
Contributor

colemars commented Aug 13, 2019

https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/nextjs

This would make sharing code and debugging other people's code a lot simpler if this was working.

I put this as a feature request because I know the skeleton works correctly in a normal environment, but I'm not experienced enough with CSB to get it working there.

@oliviertassinari oliviertassinari added the external dependency Blocked by external dependency, we can’t do anything about it label Aug 13, 2019
@oliviertassinari
Copy link
Member

@colemars Should this bug be opened on Codesandbox side instead? I don't see anything wrong on our side. The cache of codesandbox seems to be wrong. It behaves like it severs a v3 version of the library while we ask for v4.

@oliviertassinari
Copy link
Member

Seems ok here: https://codesandbox.io/s/nextjs-6j8u7.

@oliviertassinari
Copy link
Member

I have opened an issue on Codesandbox side. You can subscribe to is if you are interested: codesandbox/codesandbox-client#2284.

@colemars
Copy link
Contributor Author

I'll definitely be saving that repo for future use. Thank you!

@oliviertassinari
Copy link
Member

@colemars Did you see the proposed solution of Codesandbox guys? Should we apply it here?

@colemars
Copy link
Contributor Author

@oliviertassinari As long as the purpose of the script is documented in the README I think it is an appropriate solution.

What do you think? Do you mind if I make a PR?

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 13, 2019

I think that we should optimize for the people using the example. I don't think that poeple with your use case are the many. It really sounds like something is off on Codesandbox side, it's a cache invalidation issue, sure.

@colemars
Copy link
Contributor Author

colemars commented Aug 13, 2019

@oliviertassinari That's a good point. If this comes up again this issue can be referred to.

The template won't be useable but it seems like the fix for the user is just a fork - so not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

2 participants