-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js skeleton example fails when importing into codesandbox #16979
Comments
@colemars Should this bug be opened on Codesandbox side instead? I don't see anything wrong on our side. The cache of codesandbox seems to be wrong. It behaves like it severs a v3 version of the library while we ask for v4. |
Seems ok here: https://codesandbox.io/s/nextjs-6j8u7. |
I have opened an issue on Codesandbox side. You can subscribe to is if you are interested: codesandbox/codesandbox-client#2284. |
I'll definitely be saving that repo for future use. Thank you! |
@colemars Did you see the proposed solution of Codesandbox guys? Should we apply it here? |
@oliviertassinari As long as the purpose of the script is documented in the README I think it is an appropriate solution. What do you think? Do you mind if I make a PR? |
I think that we should optimize for the people using the example. I don't think that poeple with your use case are the many. It really sounds like something is off on Codesandbox side, it's a cache invalidation issue, sure. |
@oliviertassinari That's a good point. If this comes up again this issue can be referred to. The template won't be useable but it seems like the fix for the user is just a fork - so not a big deal. |
https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/nextjs
This would make sharing code and debugging other people's code a lot simpler if this was working.
I put this as a feature request because I know the skeleton works correctly in a normal environment, but I'm not experienced enough with CSB to get it working there.
The text was updated successfully, but these errors were encountered: