Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@material-ui/icons needs updating #17251

Closed
2 tasks done
colemars opened this issue Aug 31, 2019 · 4 comments
Closed
2 tasks done

@material-ui/icons needs updating #17251

colemars opened this issue Aug 31, 2019 · 4 comments
Labels
duplicate This issue or pull request already exists package: icons Specific to @mui/icons

Comments

@colemars
Copy link
Contributor

colemars commented Aug 31, 2019

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

At least the Eco family of icons is missing from @material-ui/icons.

Expected Behavior 🤔

All Icons present at https://material.io/resources/icons are present in @material-ui/icons.

Context

I don't mind making a pull request - but I saw in the commit history there is a script you run to update the icons.

Unfortunately, I can't get the script to work for me. Looks like the URLs that are being fetched (Ex: https://material.io/resources/icons/static/icons/outline-accessible-24px.svg) aren't valid anymore.

@colemars colemars changed the title Missing Icons from material.io @material-ui/icons needs updating Aug 31, 2019
@colemars
Copy link
Contributor Author

Looks like some Icons present in https://material.io/resources/icons are not present in https://material.io/resources/icons/static/data.json.

Given that, I'm not sure much can be done with the script.

@oliviertassinari
Copy link
Member

Moving the discussion to #12251

@colemars
Copy link
Contributor Author

colemars commented Aug 31, 2019

@oliviertassinari that discussion seems to be focused around size and icons that have been completely removed (not available at material.io any longer), no?

That isn't the issue here.

@oliviertassinari
Copy link
Member

We can extend the scope. If the issue was only about old icons missing, we could close it, this legitimate that it stays open.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 20, 2022
@zannager zannager added the package: icons Specific to @mui/icons label Dec 20, 2022
@zannager zannager added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists package: icons Specific to @mui/icons
Projects
None yet
Development

No branches or pull requests

3 participants