Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Outdated TooltipClassKey type #18600

Closed
dufia opened this issue Nov 27, 2019 · 5 comments · Fixed by #18645
Closed

[Tooltip] Outdated TooltipClassKey type #18600

dufia opened this issue Nov 27, 2019 · 5 comments · Fixed by #18645
Assignees
@dufia
Labels
component: tooltip This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@dufia
Copy link
Contributor

dufia commented Nov 27, 2019 •
edited
Loading

https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Tooltip/Tooltip.d.ts#L49 should also include the arrow key. A problem if you are using TS.
@oliviertassinari oliviertassinari added component: tooltip This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. typescript labels Nov 27, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 27, 2019 •
edited
Loading

@dufia Thanks for the report.

diff --git a/packages/material-ui/src/Tooltip/Tooltip.d.ts b/packages/material-ui/src/Tooltip/Tooltip.d.ts
index 4347a73c2..4241b22bb 100644
--- a/packages/material-ui/src/Tooltip/Tooltip.d.ts
+++ b/packages/material-ui/src/Tooltip/Tooltip.d.ts
@@ -42,6 +42,8 @@ export type TooltipClassKey =
   | 'popper'
   | 'popperInteractive'
   | 'tooltip'
+  | 'tooltipArrow'
+  | 'arrow'
   | 'touch'
   | 'tooltipPlacementLeft'
   | 'tooltipPlacementRight'

@oliviertassinari oliviertassinari changed the title You can't style the tooltip arrow because TooltipClassKey type is missing the arrow key [Tooltip] Outdated TooltipClassKey type Nov 30, 2019
@oliviertassinari
Copy link
Member

@dufia Do you want to work on a pull request?

@dufia
Copy link
Contributor Author

dufia commented Dec 1, 2019

@oliviertassinari I'd love to do it, please assign me

@dufia dufia mentioned this issue Dec 1, 2019
Merged
1 task
@dufia
Copy link
Contributor Author

dufia commented Dec 2, 2019 •
edited
Loading

Hey, I've noticed 4.7.1 was released and it included this fix. But somehow, it didn't make it into the released code. When I check my node_modules for @material-ui/core/Tooltip/Tooltip.d.ts, type TooltipClassKey remains unchanged. Any ideas why?

I definitely have 4.7.1 installed.

@eps1lon
Copy link
Member

eps1lon commented Dec 2, 2019

@dufia #18645 was not included in 4.7.1. It was released before the PR was merged: v4.7.1...master

@avocadowastaken avocadowastaken mentioned this issue Dec 10, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dufia dufia

Labels
component: tooltip This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tooltip] Add missing classes type definitions
3 participants
@oliviertassinari @dufia @eps1lon