Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disableElevation to Button Group #20744

Closed
ghost opened this issue Apr 24, 2020 · 2 comments · Fixed by #20747
Closed

Add disableElevation to Button Group #20744

ghost opened this issue Apr 24, 2020 · 2 comments · Fixed by #20747
Labels
component: ButtonGroup The React component. new feature New feature or request ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@ghost
Copy link

ghost commented Apr 24, 2020 •
edited by ghost
Loading

Recently the disableElevation prop was added to the Button component #18744. However, this prop was not added to the ButtonGroup component.

Could disableElevation prop be added to the ButtonGroup component to make it consistent with the Button component?
@oliviertassinari oliviertassinari added the component: ButtonGroup The React component. label Apr 24, 2020
@oliviertassinari
Copy link
Member

@Andrew5569 Great idea, do you want to give it a try? :)

@oliviertassinari oliviertassinari added new feature New feature or request ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Apr 24, 2020
@ghost
Copy link
Author

ghost commented Apr 24, 2020

Sure I can do that 👍

@ghost ghost mentioned this issue Apr 24, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ButtonGroup The React component. new feature New feature or request ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ButtonGroup] Add disableElevation prop
1 participant
@oliviertassinari