Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Inconsistent horizontal paddings #20828

Closed
2 tasks done
esseswann opened this issue Apr 28, 2020 · 3 comments
Closed
2 tasks done

[Tabs] Inconsistent horizontal paddings #20828

esseswann opened this issue Apr 28, 2020 · 3 comments
Labels
component: tabs This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Milestone
v5-beta

Comments

@esseswann
Copy link
Contributor

esseswann commented Apr 28, 2020 •
edited
Loading

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When variant="standard" the tabs horizontal paddings are 12px which makes the overall looks inconsistent

image

Moreover, the official spec specifies standard 16px
image

Expected Behavior 🤔

Horizontal paddings should be 16px

Steps to Reproduce 🕹

Edit trusting-cloud-qsktx

Tech Version
Material-UI v4.9.12
@esseswann esseswann changed the title [Tabs] Mobile tabs inconsistent horizontal paddings [Tabs] Tabs inconsistent horizontal paddings Apr 28, 2020
@esseswann esseswann changed the title [Tabs] Tabs inconsistent horizontal paddings [Tabs] Inconsistent horizontal paddings Apr 28, 2020
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists component: tabs This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process and removed duplicate This issue or pull request already exists labels Apr 28, 2020
@oliviertassinari
Copy link
Member

Related to #15324

@esseswann
Copy link
Contributor Author

@oliviertassinari Can I fix it for 4.*?

@oliviertassinari oliviertassinari added this to the v5 milestone Apr 29, 2020
@oliviertassinari
Copy link
Member

Fixed in #26458.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
v5-beta
Development

No branches or pull requests
2 participants
@oliviertassinari @esseswann