Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip onDelete not triggered when used with Select renderValue #21378

Closed
2 tasks done
rbarkhouse opened this issue Jun 9, 2020 · 1 comment
Closed
2 tasks done

Chip onDelete not triggered when used with Select renderValue #21378

rbarkhouse opened this issue Jun 9, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@rbarkhouse
Copy link

rbarkhouse commented Jun 9, 2020

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

I am using Chips to render the values of my Select (which is set to "multiple"). I want the delete button of the ship to remove it from the selection. When I click the delete button of the chip, however, the Select popup underneath is activated instead -- my onDelete never gets called.

Expected Behavior 🤔

Clicking the Chip's delete button should trigger the onDelete function

Steps to Reproduce 🕹

Demo: https://codesandbox.io/s/multi-select-with-chips-g3jf4

Steps:

  1. Start with multi Select
  2. Define a renderValue function that returns Chips for each item, with an onDelete function on each Chip.
  3. Run the app, select a few choices from the Select
  4. Click the delete buttons on the chips -- the onDelete function is not fired

Context 🔦

"Multi-select with Chips" is a popular concept with our UX designers and I would like to provide a fully functional solution.

Your Environment 🌎

Tech Version
Material-UI v4.?.?
React 16.13.1
Browser Chrome
TypeScript No
etc.
@rbarkhouse rbarkhouse added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 9, 2020
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 9, 2020
@oliviertassinari
Copy link
Member

Duplicate of #18658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants