-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5alpha LoadingButton rename to PendingButton? #21906
Comments
Duplicate of #21593 |
Sorry @oliviertassinari I was not clear; my suggestion is for The linked suggestion is for the prop Can you please reopen & reconsider? |
The concern is identical, shouldn't we rename the component too for consistency with the name of the prop? |
Good question! My vision for your cool button is to use for any 'not ready' status, which includes:
These are all 'pending' uses, but not all 'loading'. Here's a 7 second demo of my use-case. |
For this use case, prefer leaving the button pristine. We encourage end-users to be able to validate the form and trigger the validation errors, rather than starting with the button disabled. |
I understand. How do you feel about waiting for computational processioning? |
Pending for the name of the state would better match what's going on. Note that in 80% of the time (I don't have any proof other than my experience building and using applications), what's pending is a network request. IMHO the whole tradeoff is about what's more accurate vs what are developers more likely to find, expect, query. The balance is leaning toward the latter. I'm locking the issue, it's a duplicate of the one linked. |
I just used the LoadingButton to be a Submit button that will not become active until the user fills the form. IMHO better UX than having an active Submit button that tempts you to push it when you're not supposed to ;)
So because your new button is can be great outside of just loading, perhaps a wider name like
PendingButton
orStatusButton
could broaden its use..The text was updated successfully, but these errors were encountered: