Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectField component missing documention for menuItems #2213

Closed
markshust opened this issue Nov 18, 2015 · 4 comments
Closed

SelectField component missing documention for menuItems #2213

markshust opened this issue Nov 18, 2015 · 4 comments
Labels
docs Improvements or additions to the documentation
Milestone
Improve the docum...

Comments

@markshust
Copy link
Contributor

This page is missing documentation for menuItems required prop. Not sure how to show text or value.

http://material-ui.com/#/components/select-fields
@markshust
Copy link
Contributor Author

valueLink and value are also undocumented.

@oliviertassinari
Copy link
Member

I confirm.
Every time I see an issue regarding missing documentation, I just want to write some code to extract it from the source code. At some point, I will end up doing it.

@markshust
Copy link
Contributor Author

The onChange event handler is also documented wrong. It should be handleChange(element, index, object).

@patrickml
Copy link

So what is the correct way to do it?

@alitaheri alitaheri added the docs Improvements or additions to the documentation label Dec 9, 2015
@alitaheri alitaheri mentioned this issue Dec 29, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
Improve the documentation
Development

No branches or pull requests
4 participants
@markshust @oliviertassinari @patrickml @alitaheri