Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircularProgress timer leak #2354

Closed
w3dot0 opened this issue Dec 3, 2015 · 4 comments
Closed

CircularProgress timer leak #2354

w3dot0 opened this issue Dec 3, 2015 · 4 comments
Labels
bug 🐛 Something doesn't work

Comments

@w3dot0
Copy link

w3dot0 commented Dec 3, 2015

See https://github.com/callemall/material-ui/blob/master/src/circular-progress.jsx#L75

Once _scalePath() is called by componentDidMount it will never terminate, even after the progress component is unmounted.

A simple fix might be to move the setTimeout call to the end of the function.

@oliviertassinari
Copy link
Member

Don't we have the same issue with the RefreshIndicator component?
Could you submit a PR with somethings like https://github.com/callemall/material-ui/blob/master/src/menus/icon-menu.jsx#L87?

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 3, 2015
@alitaheri alitaheri modified the milestone: 0.14.0 Release Dec 9, 2015
@oliviertassinari oliviertassinari removed this from the 0.14.0 Release milestone Dec 22, 2015
@alitaheri alitaheri added this to the 0.14.1 Release milestone Dec 30, 2015
@wenzowski
Copy link

This still seems to be an issue in 0.14.4

@oliviertassinari
Copy link
Member

@wenzowski What makes you say so?

@wenzowski
Copy link

@oliviertassinari Was my own fault for conditionally rendering the component instead of passing status="hide". As long as status is set properly, there's no leak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

4 participants