-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Menu] Does not display in Popover #2450
Comments
Looks like you are right 😳. https://github.com/callemall/material-ui/blob/master/src/menus/menu.jsx#L154 |
I hope so, but I didn't just want to submit a PR without opening an issue first, in case it was that way for a reason, or other would break other components if they depend on this property, and don't set it explicitly. |
@oliviertassinari It was there for the previous way of using it. when popover wan't around anymore. I think we can remove it. @mbrookes Will you do the honors? 👍 👍 Thanks for creating this issue here. |
Remove absolute positioning - addresses #2450
Fixed in #2455. |
Per gitter discussion, because the Menu component has
position:absolute
, it falls outside normal HTML flow when rendered inside a Popover, and so does not appear.The Popover collapses to 0 width and height if there are no other children, or collapses to the size of the other children and shows only the portion of Menu that this exposes.
As a workaround you can applying
style={{position: 'static'}}
to Menu, but it would be preferable if it was un-positioned (or relatively positioned) by default. Any component that uses menu and requires it to be absolutely positioned can set that itself.The text was updated successfully, but these errors were encountered: