-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snackbar] should be in root of document like Dialog? #2572
Comments
I'm currently working on it, see #2562.
We are using
I don't think that we need to use the |
Cool, and yes, I only need one at a time, but when the snackbar is in a nested element, I think it will not be on top consistently if it is not placed in the root element? No matter how high the z-index, because of html hierarchy and ultimately depends on its parent's Or is z-index supposed to work differently when it's fixed, because it's fixed now and it's still behind its parent components, no matter what z-index I add to it. Did you mean For example, if you would add two things consecutively very quickly, and only one |
@TrySpace I have just merged #2562 that should address your first point.
I still think that this should be handled by a single Snackbar. We could improve this existing behavior by adding a minimum time opened.
You are probably right. I have found an issue that may be linked #1824. |
@oliviertassinari : Can this issue be closed? The linked issue is closed as well and it looks like you had already merged the PR to address the issue. |
@tintin1343 If we close this issue, it would be a |
Closing this issue. Refer to the above comments for more information. |
Hi. This was closed a long back but still, I feel nested fixed snackbars is still an issue. I have created a fiddle with scenarios I know https://jsfiddle.net/Zword/x13zwd9a/3/ . Using createPortal of 'react-dom' should fix this. I can make changes and raise a PR |
When using
Snackbar
in a nested component, no amount of z-index is going to help it get on top.Are there plans to make this work like dialog, so it will always be on top?
Is it also going to support prop
open
like the newDialog
, or will this mean problems with the timer?The text was updated successfully, but these errors were encountered: