Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] with scrollable content cut off on mobile #2758

Closed
ulrichSchreiner opened this issue Jan 2, 2016 · 10 comments
Closed

[Dialog] with scrollable content cut off on mobile #2758

ulrichSchreiner opened this issue Jan 2, 2016 · 10 comments
Labels
duplicate This issue or pull request already exists

Comments

@ulrichSchreiner
Copy link

hi,

i have a dialog with autoScrollBodyContent={true} and it works on a desktop. but when opening the dialog on a mobile device (nexus6), the scrollbar is not on the right edge of the dialog it is about 1cm inside the dialog. when using the chrome-inspector you can simulate this behaviour with other small devices too (iphone, etc).

when removing the style

box-shadow: 0 14px 45px rgba(0, 0, 0, 0.25), 0 10px 18px rgba(0, 0, 0, 0.22); 

with the inspector, the scrollbar appears exactly on the right side of the dialog. but the shadow disappears :-(

/usc

@chungwong
Copy link

To be more precise, by adding a overflow-y: auto to the same element you mentioned will fix the problem

EDIT: oh my my, it is actually a Paper element with zDepth=4, guess https://github.com/callemall/material-ui/blob/v0.14.4/src/dialog.jsx#L218 is where things should be happening

@chungwong
Copy link

Hi Nathan, why is this simply closed? Is it resolved in v0.15?

@nathanmarks
Copy link
Member

Hey @chungwong,

Sorry, I mistook this for another dialog issue that was a dupe of another.

@nathanmarks nathanmarks reopened this Apr 13, 2016
@nathanmarks nathanmarks added the bug 🐛 Something doesn't work label Apr 13, 2016
@nathanmarks nathanmarks changed the title Dialog with scrollable content [Dialog] with scrollable content Apr 13, 2016
@nathanmarks nathanmarks added design: material This is about Material Design, please involve a visual or UX designer in the process and removed bug 🐛 Something doesn't work labels Apr 13, 2016
@nathanmarks
Copy link
Member

@chungwong Although, the material design spec calls for full screen dialogs on mobile.

@nathanmarks nathanmarks changed the title [Dialog] with scrollable content [Dialog] with scrollable content cut off on mobile Apr 13, 2016
@chungwong
Copy link

@nathanmarks , I believe there is something wrong here.

It is not related to the spec at all, it is the position of the scroll bar(see attached). And it is really is a bug(or conflict) caused by the Paper element.

dialog

@nathanmarks
Copy link
Member

@chungwong Got it. Thanks for the screenshot dude!

@luandro
Copy link

luandro commented Jun 5, 2016

The Dialog is pretty much unusable on mobile if the keyboard needs to be brought up. No way to fix this?

@jamespizzurro
Copy link

This is still an issue as of v0.15.2. @chungwong's temporary fix works for now though.

@zetos
Copy link

zetos commented Sep 29, 2016

I am running into the same problem as the screenshot of @chungwong posted. The scroll bar is wrong placed, even on the material-ui docs. I dont see the same bug using Firefox though..

screenshot from 2016-09-29 13-17-06-crop

@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari
Copy link
Member

I'm closing as a duplicate of #7438

@oliviertassinari oliviertassinari marked this as a duplicate of #7438 Jul 28, 2017
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed component: dialog This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

7 participants