Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Font weight consolidation #28327

Closed
michaldudak opened this issue Sep 14, 2021 · 6 comments · Fixed by #28081
Closed

[website] Font weight consolidation #28327

michaldudak opened this issue Sep 14, 2021 · 6 comments · Fixed by #28081
Labels
website Pages that are not documentation-related, marketing-focused.

Comments

@michaldudak
Copy link
Member

michaldudak commented Sep 14, 2021

According to Edge's CSS Overview tool, we still have occurrences of IBM Plex Sans at 600 weight:

image

As we don't specify font-face at this weight, we should replace them with either 500 or 700.

As a side note, perhaps using fewer font sizes would make the site look more consistent.

cc @danilo-leal

@michaldudak michaldudak added the website Pages that are not documentation-related, marketing-focused. label Sep 14, 2021
@danilo-leal
Copy link
Contributor

Oh, shoot. I'm going to look for those extra 600 instances that got lost there. I think that using three (400, 500 and 700) weights is very ok, it's already very limited.

@danilo-leal
Copy link
Contributor

Found some of them, in 7 files to be more precise. Removed it on the refinement PR. The other instances aren't from the new website pages I guess!

@michaldudak
Copy link
Member Author

Great, thanks!

@eps1lon
Copy link
Member

eps1lon commented Sep 15, 2021

Found some of them, in 7 files to be more precise. Removed it on the refinement PR.

@danilo-leal Is this PR already open? If so and the PR fixes the issue, then please link this issue from the PR so that GitHub automatically closes the issue, once we merge the PR.

@danilo-leal
Copy link
Contributor

danilo-leal commented Sep 15, 2021

@danilo-leal Is this PR already open? If so and the PR fixes the issue, then please link this issue from the PR so that GitHub automatically closes the issue, once we merge the PR.

I pushed the changes on the #28081 PR, sorry for not mentioning before! It's merged already, here's the commit: 7aca025

@michaldudak michaldudak linked a pull request Sep 15, 2021 that will close this issue
13 tasks
@michaldudak
Copy link
Member Author

I'm closing this issue, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants