-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Font weight consolidation #28327
Comments
Oh, shoot. I'm going to look for those extra 600 instances that got lost there. I think that using three (400, 500 and 700) weights is very ok, it's already very limited. |
Found some of them, in 7 files to be more precise. Removed it on the refinement PR. The other instances aren't from the new website pages I guess! |
Great, thanks! |
@danilo-leal Is this PR already open? If so and the PR fixes the issue, then please link this issue from the PR so that GitHub automatically closes the issue, once we merge the PR. |
I pushed the changes on the #28081 PR, sorry for not mentioning before! It's merged already, here's the commit: 7aca025 |
I'm closing this issue, then. |
According to Edge's CSS Overview tool, we still have occurrences of IBM Plex Sans at 600 weight:
As we don't specify font-face at this weight, we should replace them with either 500 or 700.
As a side note, perhaps using fewer font sizes would make the site look more consistent.
cc @danilo-leal
The text was updated successfully, but these errors were encountered: