-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar behavior on v5 documentation page #28415
Comments
Hey @Pablion, thanks for reporting it! We'll work on a fix for the search div, to accommodate the Regarding the search result modal, we have been working on a redesign for it which is almost ready to go. It will definitely improve the experience of browsing through the documentation. Feel free to check it out and leave your feedback! Given that, you can either give a shot at fixing the current behavior you reported yourself (bad word wrap) — a nice opportunity to practice if you haven't opened a fix for the library yet — or wait just a bit more for the revamped design. Hope it helps and thanks again. :) |
@danilo-leal Great suggestions for PR. I will try to work on the bad word wrap tommorow. Good opportunity for me. |
@Pablion Thought a bit more about this and although it is indeed a good opportunity for contributing, it doesn't seem to be worth it as we're very close to launching the redesigned search as a whole. :( But hey, thanks for reporting again. I'm sure another good thing will come up for you to experiment with contributing to MUI! |
@Pablion Hey! We have just released the new search experience. Hope you like it :) |
@danilo-leal Wow, that's a very quick fix. This new UI fixed all issues I raised. But after some simples test, I found one behaviour was worse than before. (should I open a new issue?) feedback
reason of problemMaybe you changed algolia engine settings? |
Yeah, we did some changes in the way the search works. We'll probably open a new PR to batch some minor fixes that went unnoticed on this release. Thanks for raising those up though, we'll get back to you soon! cc @siriwatknp |
I think the new way of search needs some improvement. When I searched for "Button" the "Toggle Button" comes first. If I encountered a third misbehavior on UX, I will create a new thread of this issue to make it clearer. |
@Pablion thanks a lot for the feedback and yes, we have changed the algolia configuration which improve most search result, here is the my test https://siriwatknp.github.io/mui-docsearch/. However, as you noticed only a few cases that still not good.
|
@danilo-leal @siriwatknp are you still following this issue althought it is marked as "closed"? |
@Pablion would it make sense to create another issue so that it is not mixed up? Here is my response to your suggestion
Good point. @danilo-leal, I think this is a quick win that we can improve. What do you think?
I think what if we swap the text to be something like this? @danilo-leal @hbjORbj what do you think?
This is hard because we don't have control to edit search configuration in algolia. But there is something that we have improve on our side. Ex, currently searching for "Butto" should show
|
@siriwatknp Since we have indentation with a hashtag for a chapter, I think swapping the two names won't be a problem. 👍 |
@siriwatknp Since we are here already, better to start a new issue next time. I like your solution on this a lot. In this way the tree shape and '#' icon becomes meaningful. Also, maybe we can make them less height(hiding the h1 title, we have tree already) or make h2 titles with Chip component so we can show more contents below? They are just occupying all the space. As for the "word after first space". I never used algolia but if it's open source maybe we can PR that as well? The point of these two points above was to use more keyboard and less mouse(like Cmd+K for search), since it's far more efficient. Sorry for the bad styling on this markdown because I'm writing in bed. |
Current Behavior 😯
Firstly, congrats on rolling out v5. It's super nice.
However, the new website seems to have an oversized font (I checked my chrome zoom level is at 100%):
I think it is also related to #28395.
Expected Behavior 🤔
Have a smaller font size in documentation header.
Steps to Reproduce 🕹
Steps:
ctrl/cmd+k
typography
Context 🔦
Nothing. Just think the documentation website should be more carefully designed.
Your Environment 🌎
The text was updated successfully, but these errors were encountered: