Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code properly #29

Closed
totty90 opened this issue Nov 10, 2014 · 4 comments
Closed

Format code properly #29

totty90 opened this issue Nov 10, 2014 · 4 comments
Labels
docs Improvements or additions to the documentation

Comments

@totty90
Copy link

totty90 commented Nov 10, 2014

https://github.com/callemall/material-ui/blob/3324f57d1b4f65d4cddb610a9c8f0c51b13d3cf6/docs/dist/js/dialog.jsx#L13

https://github.com/callemall/material-ui/blob/3324f57d1b4f65d4cddb610a9c8f0c51b13d3cf6/docs/dist/js/dialog.jsx#L33

Inconsistent indentation: https://github.com/callemall/material-ui/blob/3324f57d1b4f65d4cddb610a9c8f0c51b13d3cf6/docs/dist/js/menu.jsx vs https://github.com/callemall/material-ui/blob/3324f57d1b4f65d4cddb610a9c8f0c51b13d3cf6/docs/dist/js/dialog.jsx
@franz-josef-kaiser
Copy link

Mixture of tabs and spaces. Should probably use a Linter during development or as Git pre-commit hook.

@totty90
Copy link
Author

totty90 commented Nov 10, 2014

maybe add a editor config file too if not already there

@franz-josef-kaiser
Copy link

@totty90 👍 (IDEs like PHPStorm, etc. have plugins to recognize that automatically)

@jtollerene
Copy link
Contributor

Totally agree. The issue we've run into is with jsx files. Most of the code is plain old javascript but if you let a formatter take over, it totally hacks up the jsx. Anyone aware of a jsx compatible plugin? We are mostly ST3 users here.

brianfeister pushed a commit to brianfeister/material-ui that referenced this issue May 1, 2017
@ctrlplusb
Changes the client side router configuration to handle redirect and "…
17a3531 
…no renderProps" cases. Fixes mui#29
@StoneCypher StoneCypher mentioned this issue May 19, 2022
Open
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@totty90 @franz-josef-kaiser @jtollerene @oliviertassinari @zannager