Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] bundled, distributable .js file #3141

Closed
futuro opened this issue Feb 2, 2016 · 6 comments
Closed

[Request] bundled, distributable .js file #3141

futuro opened this issue Feb 2, 2016 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@futuro
Copy link

futuro commented Feb 2, 2016

Hey all,

Is it possible to get a prebuilt, bundled version of Material-UI, preferably devoid of the React/ReactWithAddons source. I'd like this feature for a couple reasons, listed below.

  • Relying on the CDN distributed React/ReactWithAddons allows my clients to pull from their cache when visiting my sites.
  • Having a prebuilt version of MUI allows me to generate externs for it, so I can use MUI with the Google Closure compiler, leading to size code savings
  • Being able to use the Closure compiler lets me bundle MUI up for use in ClojureScript projects, which is currently complicated.

So having access to a version of Material-UI that is already bundled for the browser, as well as not having the React source inside of that bundle (I've tried bundling it myself a couple times, but I'm a little too ignorant of the build processes to feel confident in my output), would be incredibly helpful.

If this sounds doable, let me know if I can help make it a reality.

@mbrookes mbrookes added the duplicate This issue or pull request already exists label Feb 2, 2016
@mbrookes
Copy link
Member

mbrookes commented Feb 2, 2016

Hi, thanks for your interest in Material-UI. Please read CONTRIBUTING.md before opening issues.

Dupe of #262.

@mbrookes mbrookes closed this as completed Feb 2, 2016
@newoga
Copy link
Contributor

newoga commented Feb 2, 2016

If this sounds doable, let me know if I can help make it a reality.

Hey @futuro, this should definitely be doable but isn't something we can prioritize at the moment. We're more than willing to accept pull requests though. If you want to give it a stab, feel free to leave a comment in #262 with what you have in mind in terms of implementation.

@mbrookes
Copy link
Member

mbrookes commented Feb 2, 2016

Was I too harsh? 😁

@futuro
Copy link
Author

futuro commented Feb 2, 2016

@mbrookes Heh, no :p You were spot on. Sorry for the noise and thanks for directing me to issue 262. I'll head that way.

@newoga
Copy link
Contributor

newoga commented Feb 2, 2016

At least @futuro offered to do something about it 😁 I'll take that any day! 👍

@mbrookes
Copy link
Member

mbrookes commented Feb 2, 2016

Absolutely! (I missed that sentence. 😊)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants