-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal] Nested modal demo wrong scroll #37330
Comments
Thanks for reporting this. Therse are actually two separate issues - the inability to close the modal with a mouse (it's still possible to close it with the Esc key). I was able to reproduce the positioning issue on Firefox as well. |
@michaldudak If nobody take it in this week, i can try to fix it, but i must read CONTRIBUTION and gain knowledge how to do it, cause the repo is huge :) Now i know only, the components are located in 'packages' :) |
Sure, go ahead. Feel free to ask if you need clarification. I'll be unavailable for two weeks starting this Thursday, but another maintainer should be able to help you. |
@michaldudak I would like to pick this up if it's still available. |
Go ahead, with not hesitate 😁 I don't have time now, maybe i can start next week, start coding, and maybe i can help you if u have trouble 😁 |
You're right? :) |
This looks like a regression from #36873, https://deploy-preview-36873--material-ui.netlify.app/base/react-modal/#nested-modal doesn't work anymore. To figure out what happened.
This looks off-topic to the first bug and the normal behavior. |
I created a separate issue #37866 for the second issue reported here. |
Duplicates
Latest version
Steps to reproduce 🕹
Link to live example:
https://mui.com/base/react-modal/#nested-modal
Steps:
Current behavior 😯
When i try to scroll or click outside on this modal(link above) nothing happend.
I can't close it on other way, than refresh page.
And as you can see on this screen:
I see only a half of this modal, cause navbar cut it, you have wrong positioning.
The same case is here:
https://mui.com/base/react-focus-trap/#basics
When i click "Open" and the focus trap is displaying:
![ss3](https://private-user-images.githubusercontent.com/64608510/239456900-3704ba33-396d-44c3-be28-b2abc1b34eb6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTM4NTMsIm5iZiI6MTczODk1MzU1MywicGF0aCI6Ii82NDYwODUxMC8yMzk0NTY5MDAtMzcwNGJhMzMtMzk2ZC00NGMzLWJlMjgtYjJhYmMxYjM0ZWI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE4MzkxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhMTQxNzhjOTA4Zjk5N2JjYzRjZDQxZmNkNGFlZmExMzg2OTE0NTRlZDlhNmM2YWE3OTM4MGYwNGM0MTNkMzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cmbUlvfNDKbuyyIFF5hj1S4dajEJVz-3xBceSM21R4I)
Then i scroll down, then click anywhere, and the similiar bug occure, i see only this:
![ss2](https://private-user-images.githubusercontent.com/64608510/239457056-2d547959-eb54-4f79-9e9c-430aec62c2a2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTM4NTMsIm5iZiI6MTczODk1MzU1MywicGF0aCI6Ii82NDYwODUxMC8yMzk0NTcwNTYtMmQ1NDc5NTktZWI1NC00Zjc5LTllOWMtNDMwYWVjNjJjMmEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE4MzkxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIyMDkyNmZlY2Y4NmE3YzExNDdiMDYzNGVhZWE1YWE2ZDMwM2NhNDE3OWU4MzhiZmVlNDg2OWI1ODc1YTc1N2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.HIQnljDqOBuYoQ05hdn3vnLS60So33gje5R_G_qxC7A)
i think a if this slide a height of navbar above i can see properly this input.
When i scroll up and click everywhere it work properly i see input bar on the bottom of the page.
Expected behavior 🤔
Work properly :) 🥇
Context 🔦
Windows 7 x64
Firefox 113.0.1
Your environment 🌎
npx @mui/envinfo
The text was updated successfully, but these errors were encountered: