Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui] Support animating unstyled components #38280

Closed
3 tasks done
michaldudak opened this issue Aug 2, 2023 · 5 comments
Closed
3 tasks done

[base-ui] Support animating unstyled components #38280

michaldudak opened this issue Aug 2, 2023 · 5 comments
Assignees
Labels
new feature New feature or request package: base-ui Specific to @mui/base

Comments

@michaldudak
Copy link
Member

michaldudak commented Aug 2, 2023

Using animations or transitions with Popper/Popup - based components turns out to be pretty hard, as it's impossible to use the function form of Popper's children (required for transitions).

We need to think of a recommended approach to this and change the structure of Base components if necessary.

Related work:

@michaldudak michaldudak converted this from a draft issue Aug 2, 2023
@michaldudak michaldudak self-assigned this Aug 2, 2023
@michaldudak michaldudak added the package: base-ui Specific to @mui/base label Aug 2, 2023
@michaldudak michaldudak changed the title [base] Document a recommended way of animating components [base] Support animating unstyled components Aug 2, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 2, 2023

Benchmarks on how to solve this:

@oliviertassinari oliviertassinari changed the title [base] Support animating unstyled components [base-ui] Support animating unstyled components Aug 2, 2023
@michaldudak michaldudak moved this to Future in Joy UI Aug 4, 2023
@michaldudak michaldudak added this to the Base UI: Stable release milestone Aug 4, 2023
@michaldudak michaldudak added the new feature New feature or request label Aug 31, 2023
@michaldudak michaldudak moved this from Future to Backlog in Joy UI Sep 4, 2023
@oliviertassinari
Copy link
Member

Another benchmark https://ariakit.org/changelog#040

@github-project-automation github-project-automation bot moved this from In progress to Done in Base UI Alpha Feb 6, 2024
@github-project-automation github-project-automation bot moved this from In progress now to Recently completed in Joy UI Feb 6, 2024
@oliviertassinari
Copy link
Member

@michaldudak Should we create a dedicated GitHub issue about Base UI animation support?

@michaldudak
Copy link
Member Author

What do you mean? We just closed this one. It may require some adjustments going forward when we use the component-per-slot API, but we'll add issues as we discover problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: base-ui Specific to @mui/base
Projects
Status: Recently completed
Development

No branches or pull requests

2 participants