Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlatButtons are not centered on the left side of the AppBar #3844

Closed
sorahn opened this issue Mar 30, 2016 · 6 comments
Closed

FlatButtons are not centered on the left side of the AppBar #3844

sorahn opened this issue Mar 30, 2016 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@sorahn
Copy link

sorahn commented Mar 30, 2016

Problem Description

Using <FlatButton /> for iconElementLeft in <AppBar /> doesn't center the item vertically.

Versions

  • Material-UI: 0.15.0-alpha.2
  • React: 0.14
  • Browser: Chrome

See this switch case here: https://github.com/callemall/material-ui/blob/master/src/AppBar/AppBar.js#L228, and look at the one right below it for 'iconElementRight'

iconElementLeft should have a conditional for for FlatButton that does the same to it as the on for the right side.

Screenshots

Actual:
actual

Expected:
expected
(I had clicked the button in this screenshot, thats why it's transparent)

same alignment as the Button in the example seen here: http://www.material-ui.com/v0.15.0-alpha.2/#/components/app-bar
@mbrookes mbrookes added duplicate This issue or pull request already exists Composability labels Mar 30, 2016
@mbrookes
Copy link
Member

@sorahn - thanks for the report.MArking as a dupe of #773 so it will be taken into account there.

@sorahn
Copy link
Author

sorahn commented Mar 30, 2016

@mbrooks did you link to the wrong bug? I don't see a thing related to the app bar there, and that bug is closed.

@sorahn
Copy link
Author

sorahn commented Mar 30, 2016

Ah ha! #773. Watching!

@mbrookes
Copy link
Member

@sorahn thanks, updated.

@sorahn
Copy link
Author

sorahn commented Mar 30, 2016

Dyslexics of the world, UNTIE! ;)

@bravo-kernel
Copy link

Dyscalculi ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bravo-kernel @mbrookes @sorahn @oliviertassinari