Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] CI fails since Node.js 18.19.0 #40173

Closed
lhilgert9 opened this issue Dec 11, 2023 · 2 comments · Fixed by #40187
Closed

[core] CI fails since Node.js 18.19.0 #40173

lhilgert9 opened this issue Dec 11, 2023 · 2 comments · Fixed by #40187
Assignees
Labels
core Infrastructure work going on behind the scenes

Comments

@lhilgert9
Copy link
Contributor

Since #40080 CI fails when running the validate-declarations script. This is caused by ts-node. It is the same issue as mentioned here. The error was not noticed because the old version (18.8.2) was still used for the CI test when the version was upgraded. My idea would therefore be to keep Node.js in version 18.8.2 for the time being until ts-node has a solution ready. Alternatively, you could change the script "ts-node --esm scripts/validateTypescriptDeclarations.mts" to "node --loader ts-node/esm scripts/validateTypescriptDeclarations.mts". However, this uses an experimental feature, so I would tend to use the former.

Current PRs, where I find the issue:

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 11, 2023
@zannager zannager added the core Infrastructure work going on behind the scenes label Dec 11, 2023
@mnajdova mnajdova assigned michaldudak and unassigned mnajdova Dec 12, 2023
@mnajdova
Copy link
Member

Thanks for the report and the investigation. I noticed the issue myself today too I would vote for reverting the commit for now too, but I would let @michaldudak check as he is mostly familiar with the infra.

@michaldudak
Copy link
Member

I agree, let's revert the problematic PR for now. We'll discuss the long-term solution within the team. I'll prepare a fix.

@ZeeshanTamboli ZeeshanTamboli removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants