Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] Adopt styling more strictly to Material Design #4084

Closed
FranBran opened this issue Apr 25, 2016 · 1 comment
Closed

[Card] Adopt styling more strictly to Material Design #4084

FranBran opened this issue Apr 25, 2016 · 1 comment
Labels
component: card This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@FranBran
Copy link

Card-components should mostly use margins instead of paddings in order to collapse spacings.

For example:

current state:
asis

expected:
adopted
@mpontikes mpontikes mentioned this issue Aug 5, 2016
Closed
13 tasks
@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Sep 17, 2016
@oliviertassinari oliviertassinari added the component: card This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari
Copy link
Member

The Card component has been reworked on the next branch. I think that this issue is now solved. Thanks for raising it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: card This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FranBran @oliviertassinari