-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align checkbox icons #4235
Comments
I am very sure of this. I think this looks just fine, may be I am wrong. The spec clearly does not mention anything. I would like the other collaborators to respond to this. @callemall/material-ui : Guys, would like you opinion about this. Thanks! |
@tintin1343 Well, if the spec doesn't mention anything, I would just keep it like it. That looks good, but my point of view is subjective. |
I mentioned to @tintin1343 that while the spec doesn't say anything specifically about checkbox alignment to multi-line text, and has no examples that I could find, the general rule does seem to be that icons are vertically centered relative to the text they accompany, so could apply here. There's no right or wrong though. |
@tintin1343 You think this issue can be closed then? |
Problem description
The problem is when the label have 2 lines the icon is not correctly centered.
This are the html of the checkbox
We solve with adding
alignItems: 'center'
to the parent of the icon + label, please add a fix or a possibility to put a value for the align items.Versions
The text was updated successfully, but these errors were encountered: