Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Allow SelectableList components to work with wrapper-based libraries #4432

Closed
jlroettger opened this issue Jun 5, 2016 · 2 comments
Closed

[List] Allow SelectableList components to work with wrapper-based libraries #4432

jlroettger opened this issue Jun 5, 2016 · 2 comments
Labels
component: list This is the name of the generic UI component, not the React module! out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@jlroettger
Copy link

Wrapper-based libraries (such as gaearon/react-dnd) are currently incompatible with SelectableList components, because the ListItems in a SelectableList can't be wrapped by anything (they must be the first-level children of a SelectableList). There was some discussion on the issue in #3103
@jlroettger
Copy link
Author

I'm about to try to integrate a SelectableList with gaearon/react-dnd; I'll report back here with my findings and/or solution. If anyone else has done a similar integration maybe they can shed some light on the problem as well.

@jlroettger
Copy link
Author

I added the functionality for SelectableLists allowing ListItems to be nested. Here's some example code that's working correctly:

untitled

Gonna do a PR

@jlroettger jlroettger mentioned this issue Jun 6, 2016
Closed
3 tasks
@jlroettger jlroettger mentioned this issue Jul 12, 2016
Closed
@mpontikes mpontikes mentioned this issue Aug 5, 2016
Closed
13 tasks
@oliviertassinari oliviertassinari added the component: list This is the name of the generic UI component, not the React module! label May 16, 2017
@oliviertassinari oliviertassinari changed the title Allow SelectableList components to work with wrapper-based libraries [List] Allow SelectableList components to work with wrapper-based libraries May 16, 2017
@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @jlroettger