Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][test] Restore issue #12831 after React 19 bump #44674

Closed
DiegoAndai opened this issue Dec 6, 2024 · 3 comments
Closed

[material-ui][test] Restore issue #12831 after React 19 bump #44674

DiegoAndai opened this issue Dec 6, 2024 · 3 comments
Assignees
@DiegoAndai
Labels
component: modal This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material test

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Dec 6, 2024 •
edited by github-actions bot
Loading

To unblock the bump to React 19, we had to modify the following test: https://github.com/mui/material-ui/pull/44672/files#diff-7fa3a77f0a07e7516ea59d68b0629b50010a3c63eb40e3e55cda303b86f8d22d

It's an obscure change in behavior in a test from #12831.

This issue is to track the investigation of where the change comes from and hopefully restore the test to its original intent.

Search keywords:
@DiegoAndai DiegoAndai added test component: modal This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Dec 6, 2024
@DiegoAndai DiegoAndai self-assigned this Dec 6, 2024
@DiegoAndai DiegoAndai mentioned this issue Dec 6, 2024
Closed
@aarongarciah
Copy link
Member

I created this issue a few months ago #43312

@DiegoAndai
Copy link
Member Author

@aarongarciah my bad, closing 😅

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoAndai DiegoAndai

Labels
component: modal This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aarongarciah @DiegoAndai