Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] render too slowly, causing brief text overlap #4528

Closed
dianafaye17 opened this issue Jun 20, 2016 · 3 comments · Fixed by #5604
Closed

[Tabs] render too slowly, causing brief text overlap #4528

dianafaye17 opened this issue Jun 20, 2016 · 3 comments · Fixed by #5604
Labels
component: tabs This is the name of the generic UI component, not the React module! performance

Comments

@dianafaye17
Copy link

When I click on a Tab, The text from the first Tab I was on briefly overlaps the text on the current Tab. This lasts about 2 seconds. It causes a bad user experience. Here is an image
of the overlap.

screen shot 2016-06-20 at 10 12 31 am

1. Have two Tabs that have a lot of data to display. 2. Click from one Tab to another. 3. Watch text overlap for about 2 seconds. - Material-UI: 0.15.0 - React: 15.0.1 - Browser: Google Chrome for Mac Version 51.0.2704.84 (64-bit)
@Serfenia
Copy link

Could you show a code example that replicates the issue?

@dianafaye17
Copy link
Author

@Serfenia Sure, just give me some time to recreate the problem with something that isn't my workplace code.

@mpontikes mpontikes mentioned this issue Aug 5, 2016
Closed
13 tasks
@oliviertassinari oliviertassinari changed the title Tabs render too slowly, causing brief text overlap [Tabs] render too slowly, causing brief text overlap Sep 17, 2016
@oliviertassinari oliviertassinari added component: tabs This is the name of the generic UI component, not the React module! and removed component: tabs This is the name of the generic UI component, not the React module! labels Oct 19, 2016
@oliviertassinari oliviertassinari mentioned this issue Nov 20, 2016
Merged
4 tasks
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 22, 2016 •
edited
Loading

An initial migration of the Tabs component has been merged on the next branch.
The component is much simpler, the TabTemplate one was removed. I'm closing this issue.
It's now up to users to handle the views they display. We may provide a helper in the future.
Hopefully, that potential future helper won't have this issue.
If you find a workaround for the master branch. We would still accept a PR for it 👍 .
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tabs] Initial migration of component
3 participants
@Serfenia @oliviertassinari @dianafaye17