Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker][TimePicker] exposing the api for TimePickerDialog and DatePickerDialog #4587

Closed
xiaofan2406 opened this issue Jun 30, 2016 · 3 comments
Closed

[DatePicker][TimePicker] exposing the api for TimePickerDialog and DatePickerDialog #4587

xiaofan2406 opened this issue Jun 30, 2016 · 3 comments
Labels
component: date picker This is the name of the generic UI component, not the React module! component: time picker This is the name of the generic UI component, not the React module!

Comments

@xiaofan2406
Copy link

This is just a suggestion.
I find myself using DatePickerDialog more often than the DatePicker. Because it gives more flexibilities in terms of how I open the dialog, and where to display the date.
Maybe having DatePickerDialog documented is going to be helpful.
@aahan96 aahan96 added the docs Improvements or additions to the documentation label Jun 30, 2016
@gchudnov
Copy link
Contributor

gchudnov commented Jul 7, 2016

Regarding the DatePickerDialog API...

Is there any reason the initial state for open is false?

It would be great to open the DatePickerDialog declaratively, e.g. using the props.open property. It looks the author of the code considered that but it wasn't implemented.

#4401 is related.

@oliviertassinari oliviertassinari added Composability and removed docs Improvements or additions to the documentation labels Sep 7, 2016
@oliviertassinari oliviertassinari changed the title exposing the api for TimePickerDialog and DatePickerDialog [DatePicker][TimePicker] exposing the api for TimePickerDialog and DatePickerDialog Sep 7, 2016
This was referenced Sep 7, 2016
Closed
Closed
@oliviertassinari oliviertassinari added the component: date picker This is the name of the generic UI component, not the React module! label Oct 19, 2016
@ndreckshage
Copy link

👍 on this!

@oliviertassinari oliviertassinari added component: time picker This is the name of the generic UI component, not the React module! and removed component: time picker This is the name of the generic UI component, not the React module! labels Nov 15, 2016
@oliviertassinari
Copy link
Member

Closing for #4787

@nathanmarks nathanmarks mentioned this issue Aug 22, 2017
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: date picker This is the name of the generic UI component, not the React module! component: time picker This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ndreckshage @gchudnov @xiaofan2406 @oliviertassinari @aahan96