You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
styles.root is computed and will have the correct color based on state (green) but if you pass in color as a style prop it'll then promptly blow it away (same if you pass in color as a prop also).
Maybe it should give you a warning if you pass in a color prop to this component?
Steps to reproduce
Versions
Material-UI: 15.x
React: 15.x
Browser: All
The text was updated successfully, but these errors were encountered:
oliviertassinari
changed the title
FontIcon will be broken if you pass a color in the style prop
[FontIcon] Will be broken if you pass a color in the style prop
May 16, 2017
We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.
Problem description
If you do
you'll see hoverColor is never used. This is because https://github.com/callemall/material-ui/blob/master/src/FontIcon/FontIcon.js#L99 does
styles.root is computed and will have the correct color based on state (green) but if you pass in color as a style prop it'll then promptly blow it away (same if you pass in color as a prop also).
Maybe it should give you a warning if you pass in a color prop to this component?
Steps to reproduce
Versions
The text was updated successfully, but these errors were encountered: