Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Should update input when focusing suggestion #4811

Closed
moshest opened this issue Jul 23, 2016 · 1 comment
Closed

[Autocomplete] Should update input when focusing suggestion #4811

moshest opened this issue Jul 23, 2016 · 1 comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@moshest
Copy link
Contributor

moshest commented Jul 23, 2016

Problem description

When I focus a suggestion, the autocomplete label remain as is. It's should update as the focused option and trigger onChange (see google.com for example).
You should create separate event for loading new suggestion only while typing.

Right now the events are confusing and make a lot of bugs.
Ie. when update searchText on onNewRequest it's get ignored because there is a menu.close(); timer that reset it with the chosen suggestion.

Steps to reproduce

Try it out on the docs.

Versions

  • Material-UI: 0.15.2
  • React: unrelated
  • Browser: unrelated
@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari oliviertassinari changed the title Autocomplete should update input when focusing suggestion [Autocomplete] Should update input when focusing suggestion Sep 18, 2016
@oliviertassinari
Copy link
Member

Closed by #4783

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

2 participants