Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Accept new List as nestedItems of ListItem #4863

Closed
Mangatt opened this issue Jul 31, 2016 · 2 comments
Closed

[List] Accept new List as nestedItems of ListItem #4863

Mangatt opened this issue Jul 31, 2016 · 2 comments
Labels
component: list This is the name of the generic UI component, not the React module!

Comments

@Mangatt
Copy link
Contributor

Mangatt commented Jul 31, 2016

Creating array of ListItems could be problematic in some cases (=ListItems are generated in separate component and enclosed in some tag), there should be allowed to use List as nestedItems.

It is same case as ul + li lists, when you need sublist, you will create new ul inside li.

What do you think?
@nehalbhanushali
Copy link

@Mangatt I agree, we could have a subList prop instead of the nestedItems prop. @nathanmarks do we have anything for that in the rewrite or any major changes in the List component?

@mpontikes mpontikes mentioned this issue Aug 5, 2016
Closed
13 tasks
@oliviertassinari oliviertassinari added the component: list This is the name of the generic UI component, not the React module! label May 16, 2017
@oliviertassinari oliviertassinari changed the title Accept new List as nestedItems of ListItem [List] Accept new List as nestedItems of ListItem May 16, 2017
@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Aug 5, 2017
@oliviertassinari
Copy link
Member

The nestedItems property was removed on the v1-beta branch. Instead, people can use normal children composition.

@oliviertassinari oliviertassinari removed the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mangatt @oliviertassinari @nehalbhanushali