Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Multiline text support #6288

Closed
kybarg opened this issue Mar 6, 2017 · 5 comments · Fixed by #6566
Closed

[TextField] Multiline text support #6288

kybarg opened this issue Mar 6, 2017 · 5 comments · Fixed by #6566
Labels
component: TextareaAutosize The React component.

Comments

@kybarg
Copy link
Contributor

kybarg commented Mar 6, 2017

I've discovered that multiline functionality hasn't been ported yet to next. Is there any chance it can be ported in next build? Thank you.
I can start PR myself, but I'm not professional in react.

  • Material-UI: next
  • React:
  • Browser:
@oliviertassinari oliviertassinari added next component: text field This is the name of the generic UI component, not the React module! labels Mar 6, 2017
@Shahrukh-Zindani
Copy link

You are right. The prop does not exist. A PR can be started to add the prop but I just want to confirm to see that it wasn't left out deliberately by the core contributors. @oliviertassinari

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 6, 2017 •
edited
Loading

I think that the multiline functionality was left out by @nathanmarks as shouldn't be too hard to implement. The single line answers 80% of the needs.

@Shahrukh-Zindani
Copy link

Don't you think that adding the prop to the API and demo would be helpful to the users who are trying to use multiline?

@oliviertassinari
Copy link
Member

@Shahrukh-Zindani Yes, I agree.

@kybarg
Copy link
Contributor Author

kybarg commented Mar 23, 2017

@oliviertassinari any updates?

@kybarg kybarg mentioned this issue Apr 10, 2017
Merged
6 tasks
@oliviertassinari oliviertassinari mentioned this issue May 21, 2017
Merged
@oliviertassinari oliviertassinari added component: TextareaAutosize The React component. and removed component: text field This is the name of the generic UI component, not the React module! labels Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: TextareaAutosize The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TextField] Make it meet guidelines kybarg/material-ui
3 participants
@oliviertassinari @kybarg @Shahrukh-Zindani