Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 Typos in v1 Docs #8058

Closed
Skaronator opened this issue Sep 5, 2017 · 3 comments
Closed

2 Typos in v1 Docs #8058

Skaronator opened this issue Sep 5, 2017 · 3 comments
Assignees
@oliviertassinari
Labels
docs Improvements or additions to the documentation

Comments

@Skaronator
Copy link
Contributor

1. -> margin

https://github.com/callemall/material-ui/blob/v1-beta/pages/api/form-control.md#props
https://material-ui-1dab0.firebaseapp.com/api/form-control/#props

2. -> margin

https://github.com/callemall/material-ui/blob/v1-beta/pages/api/text-field.md#props
https://material-ui-1dab0.firebaseapp.com/api/text-field/#props

/cc @rosskevin
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 5, 2017
@oliviertassinari
Copy link
Member

Would you mind submitting a PR? :)

@oliviertassinari
Copy link
Member

Actually, I don't get it, @Skaronator what's the issue?

@oliviertassinari oliviertassinari added the waiting for 👍 Waiting for upvotes label Sep 6, 2017
@Skaronator
Copy link
Contributor Author

Skaronator commented Sep 6, 2017 •
edited
Loading

Take a look on description on the margin row. On the TextField page it is just "If dense" and on the FormControl page there is also just "If dense" + some overlaping due to a |:

image

What would be the correct description for those?
"dense will minimize the overall size of the element by reducing the margins"

I'm fairly new and don't know the difference between normal and none. Shouldn't normal be standard and not none?

@oliviertassinari oliviertassinari removed the waiting for 👍 Waiting for upvotes label Sep 6, 2017
@oliviertassinari oliviertassinari self-assigned this Sep 7, 2017
@oliviertassinari oliviertassinari mentioned this issue Sep 7, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Skaronator @oliviertassinari