Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LeftNav] Support show LeftNav with wipe gesture #848

Closed
ysmood opened this issue Jun 15, 2015 · 6 comments · Fixed by #868
Closed

[LeftNav] Support show LeftNav with wipe gesture #848

ysmood opened this issue Jun 15, 2015 · 6 comments · Fixed by #868
Labels
component: menu This is the name of the generic UI component, not the React module!

Comments

@ysmood
Copy link
Contributor

ysmood commented Jun 15, 2015

Such as wipe from screen's left edge to show LeftNav.

@pomerantsev
Copy link
Contributor

I implemented swipe to close functionality, and I can make this work as well if people are interested. @ysmood, are there any other material design libraries doing it?

@cgestes
Copy link
Contributor

cgestes commented Jun 15, 2015

interested, can you provide a PR ? :)

(I would like it to works for opening in some cases too)

@pomerantsev
Copy link
Contributor

I can try to implement this during weekend.
There should probably be some restrictions.
Like only allowing this behavior when visual viewport width equals layout viewport width (which means that you can't scroll horizontally).
There's also a corner case when there are two or more nav components on the screen - we'll have to deal with this somehow.

@pomerantsev
Copy link
Contributor

@ysmood, @cgestes can either of you guys test my implementation and say if that the way it works feels fine to you?
This PR might also benefit from a code review, so feel free to comment.

@hai-cea hai-cea changed the title Support show LeftNav with wipe gesture [LeftNav] Support show LeftNav with wipe gesture Jun 19, 2015
@cgestes
Copy link
Contributor

cgestes commented Jun 29, 2015

Looks better.

Some glitches:

  • swiping on the body of my test project do not works. (at the bottom of the page)
  • swiping to open the leftnav (enough to open it but not complete), then clicking on the AppBar (not the button) twice produce strange behaviors. (first time it close the appbar as expected, second time the appbar appear but should not!)

@cgestes
Copy link
Contributor

cgestes commented Jun 29, 2015

Humm wait. not sure what I tried.

On master if I click anywhere on the webpage the LeftNav open. (on android)
and the swipping behavior does not work at all.

It's close to be unusable.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: menu This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants