Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Popover CSS API is not available #8827

Closed
1 task done
cherniavskii opened this issue Oct 24, 2017 · 2 comments
Closed
1 task done

[Menu] Popover CSS API is not available #8827

cherniavskii opened this issue Oct 24, 2017 · 2 comments
Labels
component: menu This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@cherniavskii
Copy link
Member

cherniavskii commented Oct 24, 2017

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

It is possible to override styles of Popover inside Menu.

Current Behavior

It is not possible to override styles of Popover inside Menu.

Steps to Reproduce (for bugs)

N/A

Context

Menu intercepts classes prop, so it is not passed to Popover component along with ...other props.
My suggestion would be adding PopoverProps, which then can be used to pass classes prop to Popover (like it is implemented in Drawer).
I can submit a PR if you are OK with this solution

Your Environment

N/A

@oliviertassinari
Copy link
Member

There is only one style in the Popover component. You can already access it with the PaperProps property. Still, it doesn't merge the classNames, I think that it should. Fixing that issue should answer your use cases. I'm not sure about adding a PopoverProps as it's already the root component. I feel like PopoverClasses would be more appropriate.

@oliviertassinari oliviertassinari added component: menu This is the name of the generic UI component, not the React module! new feature New feature or request good first issue Great for first contributions. Enable to learn the contribution process. labels Oct 24, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants