-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Increase clarity around the usage of font icons #13628
Conversation
With this current sample code, I was not able to get `SendIcon` to work. I was able to import `SendIcon` from`'@material-ui/core/Send'` and use it to display the `SendIcon` within the button.
SendIcon
@JosephMart Thank you for raising the concern, I have added a comment to guide people. |
@oliviertassinari This is why we eliminated font icon examples from the docs, (other than in the Icon section). They don't work out-of-the box, and cause this kind of confusion. Any idea why this one is a font icon? |
@mbrookes It demonstrates both solutions can be switched, same output. |
We already have the Icons section for that, whereas this example has zero discoverability. It seems a bit random to stick a font icon in here. Your call. |
As long as we have a visual regression test that compares font icons with svg icons, side by side in a button, I'm happy. |
Aha, right. If this comes up again, I'll create s dedicated regression test and remove the font icon from the Button examples. |
With this current sample code, I was not able to get
SendIcon
to work.I was able to import
SendIcon
from'@material-ui/core/Send'
and use it to display theSendIcon
within the button.