Ripple effect in Firefox #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with remote master
|
Works great! 👍 |
zannager
added
the
package: styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems FireFox has a few more requirements to the syntax used by the animation attribute, such as the order and presence of certain items, no quotes allowed, and some other things.
I updated whatever I could find, and tested it on (Mac) Chrome (stable), FireFox (34.0 and DeveloperEdition) and Safari (8.0.2). Can someone do a test on Windows as well?
@hai-cea: there is a
.pulsatesomewhere, is it somewhere in the docs example as an element as well?ref. #129
p.s.: The change in tabs and other things is because of the presence of the ".editorconfig" file, it seems these files were not correct yet.