Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slide] Convert to function component #15344

Merged
merged 12 commits into from
Apr 19, 2019
Merged

[Slide] Convert to function component #15344

merged 12 commits into from
Apr 19, 2019

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Apr 14, 2019 •
edited by eps1lon
Loading

Breaking Change

Child must be able to hold a ref.

@joshwooding joshwooding added new feature New feature or request component: Slide labels Apr 14, 2019
@joshwooding joshwooding mentioned this pull request Apr 14, 2019
Closed
29 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 14, 2019 •
edited
Loading

@material-ui/core: parsed: -0.21% 😍, gzip: -0.21% 😍

Details of bundle changes.

Comparing: ccc466a...f4316db

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.21% -0.21% 312,618 311,951 84,447 84,271
@material-ui/core/Paper 0.00% -0.03% 67,279 67,279 19,968 19,963
@material-ui/core/Paper.esm 0.00% -0.01% 60,640 60,640 18,884 18,883
@material-ui/core/Popper 0.00% -0.03% 34,907 34,907 11,812 11,809
@material-ui/core/Textarea 0.00% 0.00% 5,327 5,327 2,291 2,291
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,771 5,771
@material-ui/core/useMediaQuery 0.00% -0.10% 2,106 2,106 974 973
@material-ui/lab 0.00% -0.00% 141,612 141,612 42,722 42,721
@material-ui/styles 0.00% -0.01% 50,833 50,833 15,013 15,012
@material-ui/system 0.00% +0.03% 🔺 11,765 11,765 3,928 3,929
Button 0.00% -0.02% 85,621 85,621 25,588 25,584
Modal 0.00% +0.02% 🔺 79,901 79,901 24,011 24,015
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 50,908 50,908 11,210 11,210
docs.main -0.12% -0.07% 648,518 647,735 201,926 201,782
packages/material-ui/build/umd/material-ui.production.min.js -0.22% -0.21% 293,911 293,250 82,492 82,317

Generated by 🚫 dangerJS against f4316db

@joshwooding joshwooding force-pushed the slide-function-component branch 3 times, most recently from 9f9c998 to d739e4f Compare April 14, 2019 13:54
@joshwooding joshwooding force-pushed the slide-function-component branch from d739e4f to b0df521 Compare April 14, 2019 13:59
@joshwooding joshwooding requested a review from eps1lon April 14, 2019 16:58
eps1lon
eps1lon reviewed Apr 14, 2019
View reviewed changes
packages/material-ui/src/Slide/Slide.js Outdated Show resolved Hide resolved
packages/material-ui/src/Slide/Slide.js Outdated Show resolved Hide resolved
eps1lon
eps1lon previously requested changes Apr 14, 2019
View reviewed changes
packages/material-ui/src/Slide/Slide.js Show resolved Hide resolved
@joshwooding joshwooding requested a review from eps1lon April 14, 2019 22:33
@joshwooding joshwooding force-pushed the slide-function-component branch from efd2c9d to 99ea912 Compare April 14, 2019 22:41
eps1lon
eps1lon reviewed Apr 14, 2019
View reviewed changes
packages/material-ui/src/Slide/Slide.js Outdated Show resolved Hide resolved
packages/material-ui/src/Slide/Slide.js Outdated Show resolved Hide resolved
packages/material-ui/src/Slide/Slide.test.js Show resolved Hide resolved
packages/material-ui/src/transitions/utils.js Outdated Show resolved Hide resolved
@joshwooding joshwooding force-pushed the slide-function-component branch from 599ddf3 to 319b057 Compare April 14, 2019 23:50
@joshwooding joshwooding requested a review from eps1lon April 14, 2019 23:51
@joshwooding joshwooding mentioned this pull request Apr 16, 2019
Closed
@eps1lon eps1lon added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 17, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 17, 2019

@joshwooding Branch has conflicts

@eps1lon eps1lon mentioned this pull request Apr 17, 2019
Closed
56 tasks
@oliviertassinari oliviertassinari added this to the v4 milestone Apr 17, 2019
@joshwooding joshwooding added PR: good for merge and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 18, 2019
@joshwooding joshwooding force-pushed the slide-function-component branch from 269a194 to 3df7d17 Compare April 18, 2019 14:48
@eps1lon eps1lon mentioned this pull request Apr 18, 2019
Merged
1 task
@oliviertassinari oliviertassinari merged commit 19d418d into mui:next Apr 19, 2019
@joshwooding joshwooding deleted the slide-function-component branch April 19, 2019 00:21
@oliviertassinari oliviertassinari added component: transitions This is the name of the generic UI component, not the React module! and removed component: Slide labels Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: transitions This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.
4 participants
@joshwooding @mui-pr-bot @eps1lon @oliviertassinari