Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Migrate to the new naming strategy #2628

Merged
merged 1 commit into from
Dec 22, 2015

Conversation

alitaheri
Copy link
Member

Fraction of #2585

This PR changes the Docs folder structure.

@oliviertassinari @newoga Is this ok? please review

@alitaheri alitaheri added docs Improvements or additions to the documentation PR: Needs Review labels Dec 22, 2015
@oliviertassinari
Copy link
Member

@subjectix Having the Page close to the examples for each components is fare better 👍.
I'm merging, I prefer rebasing the other PR (#2592, #2622)

oliviertassinari added a commit that referenced this pull request Dec 22, 2015
[Docs] Migrate to the new naming strategy
@oliviertassinari oliviertassinari merged commit 2ab3817 into mui:master Dec 22, 2015
@oliviertassinari
Copy link
Member

I'm even wondering if we shouldn't push this pattern further.
What about having in the src folder, one folder per component and then everything regarding this component

  • the source code (browser, native)
  • the examples
  • the page documentation
  • the readme
  • the tests.

@alitaheri alitaheri mentioned this pull request Dec 22, 2015
5 tasks
@alitaheri alitaheri deleted the docs-naming-strategy branch December 22, 2015 10:32
@alitaheri
Copy link
Member Author

@oliviertassinari That's a great idea! I'd love that 😁 But we should migrate them separately and then merge. For this, we can't some of both. There should be a roadmap for this. But I love the idea. 👍 👍

@newoga
Copy link
Contributor

newoga commented Dec 22, 2015

I completely agree @oliviertassinari! I had the same thoughts earlier too. I think that will make more sense when react native comes into play since there will be naturally more than one file per component. 👍

@oliviertassinari
Copy link
Member

sense when react native comes into play

Yes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants