[RaisedButton] backgroundColor prop was previously ignored

[ffxsam]

Strange. This is documented, though it was apparently ignored in the code.

[oliviertassinari]

Looks like it the same for the labelColor property.

[oliviertassinari]

What about using this logic?

} else {
  if (props.backgroundColor) {
    backgroundColor = props.backgroundColor || raisedButton.secondaryColor;
  }
  if (props.labelColor) {
    labelColor = props.labelColor || raisedButton.secondaryTextColor;
  }
}

[ffxsam]

Well, you're already setting your defaults here:

  let backgroundColor = raisedButton.color;
  let labelColor = raisedButton.textColor;

So in the proposed else block, why set backgroundColor to raisedButton.secondaryColor if props.backgroundColor is undefined? I would recommend either:

1. Get rid of these two lines and implement your suggestion.
2. Leave those two lines in, and I'd modify my code to be:

  } else {
    if (props.backgroundColor) {
      backgroundColor = props.backgroundColor;
    }
    if (props.labelColor) {
      labelColor = props.labelColor;
    }
  }

[ffxsam]

Actually, to change option 1 above.. I wouldn't get rid of the lines, just change them to:

let backgroundColor, labelColor;

I'm a proponent of declaring variables at the top of scopes so they're easy to find.

[ffxsam]

Hmm, this might be a mistake actually? There are no such properties on raisedButton in src/styles/getMuiTheme.js

[ffxsam]

I went with option 2 above, because it introduces the least amount of changes. If we had gone with option 1, buttons without primary or secondary set would've been a breaking change.

[oliviertassinari]

That looks good to me 👍.

[alitaheri]

This is great, thanks 👍 👍